Adam Manzanares wrote:
> On Thu, Jun 23, 2022 at 07:45:36PM -0700, Dan Williams wrote:
> > Root decoders are responsible for hosting the available host address
> > space for endpoints and regions to claim. The tracking of that available
> > capacity can be done in iomem_resource directly. As a result, root
> > decoders no longer need to host their own resource tree. The
> > current ->platform_res attribute was added prematurely.
> >
> > Otherwise, ->hpa_range fills the role of conveying the current decode
> > range of the decoder.
> >
> > Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> > ---
> > drivers/cxl/acpi.c | 17 ++++++++++-------
> > drivers/cxl/core/pci.c | 8 +-------
> > drivers/cxl/core/port.c | 30 +++++++-----------------------
> > drivers/cxl/cxl.h | 6 +-----
> > 4 files changed, 19 insertions(+), 42 deletions(-)
> >
> > diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> > index 40286f5df812..951695cdb455 100644
> > --- a/drivers/cxl/acpi.c
> > +++ b/drivers/cxl/acpi.c
> > @@ -108,8 +108,10 @@ static int cxl_parse_cfmws(union acpi_subtable_headers *header, void *arg,
> >
> > cxld->flags = cfmws_to_decoder_flags(cfmws->restrictions);
> > cxld->target_type = CXL_DECODER_EXPANDER;
> > - cxld->platform_res = (struct resource)DEFINE_RES_MEM(cfmws->base_hpa,
> > - cfmws->window_size);
> > + cxld->hpa_range = (struct range) {
> > + .start = cfmws->base_hpa,
> > + .end = cfmws->base_hpa + cfmws->window_size - 1,
> > + };
> > cxld->interleave_ways = CFMWS_INTERLEAVE_WAYS(cfmws);
> > cxld->interleave_granularity = CFMWS_INTERLEAVE_GRANULARITY(cfmws);
> >
> > @@ -119,13 +121,14 @@ static int cxl_parse_cfmws(union acpi_subtable_headers *header, void *arg,
> > else
> > rc = cxl_decoder_autoremove(dev, cxld);
> > if (rc) {
> > - dev_err(dev, "Failed to add decoder for %pr\n",
> > - &cxld->platform_res);
> > + dev_err(dev, "Failed to add decoder for [%#llx - %#llx]\n",
> > + cxld->hpa_range.start, cxld->hpa_range.end);
>
> Minor nit, should we add range in our debug message?
>
> + dev_err(dev, "Failed to add decoder for range [%#llx - %#llx]\n",
Sure, but I shortened it to:
"Failed to add decode range [%#llx - %#llx]\n",
...just to keep it under 80 columns.
> Otherwise, looks good.
>
> Reviewed by: Adam Manzanares <a.manzanares@xxxxxxxxxxx>
Thanks.
