On Fri, Jul 08, 2022 at 10:14:11AM -0400, Jim Quinlan wrote: > On Wed, Jul 6, 2022 at 7:12 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > On Fri, Jul 01, 2022 at 12:27:23PM -0400, Jim Quinlan wrote: > > > Add a mechanism to identify standard PCIe regulators in the DT, allocate > > > them, and turn them on before the rest of the bus is scanned during > > > pci_host_probe(). > > > ... > > > +static int pci_subdev_regulators_add_bus(struct pci_bus *bus); > > > +static void pci_subdev_regulators_remove_bus(struct pci_bus *bus); > > > > I think these forward declarations are unnecessary. I can remove them > > if you agree. > > It is up to you. I have a commit-set ready that will make a number of > improvements to our driver. > One of them removes all forward declarations. Other commits concern > other suggestions you > have made, e.g. rename brcm_pcie_linkup() to brcm_pcie_start_link(). If you're planning a v2, I'd drop the declarations there. No point in adding them, only to remove them in a future patch (unless we need them in the interim, of course, but in this case I don't think we do). Bjorn