On Thu, Jun 23, 2022 at 07:45:00PM -0700, Dan Williams wrote: > tl;dr: 46 patches is way too many patches to review in one sitting. Jump > to the PATCH SUMMARY below to find a subset of interest to jump into. > > The series is also posted on the 'preview' branch [1]. Note that branch > rebases, the tip of that branch at time of posting is: > > 7e5ad5cb1580 cxl/region: Introduce cxl_pmem_region objects > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl.git/log/?h=preview > Dan, I'm seeing these smatch reports while working off of the preview branch. Perhaps 0-day has already sent these reports aligned to patches. drivers/cxl/core/port.c:1482 cxl_decoder_alloc() warn: is 'alloc' large enough for 'struct cxl_root_decoder'? 0 drivers/cxl/core/port.c:1515 cxl_decoder_alloc() error: potentially dereferencing uninitialized 'cxld'. drivers/cxl/core/hdm.c:457 cxld_set_interleave() error: uninitialized symbol 'eig'. drivers/cxl/core/hdm.c:458 cxld_set_interleave() error: uninitialized symbol 'eiw'. drivers/cxl/core/region.c:192 cxl_region_decode_commit() error: uninitialized symbol 'rc'. drivers/cxl/core/region.c:201 cxl_region_decode_commit() error: uninitialized symbol 'rc'. drivers/cxl/core/region.c:443 alloc_hpa() error: uninitialized symbol 'res'. drivers/cxl/core/region.c:964 cxl_port_setup_targets() error: uninitialized symbol 'peig'. drivers/cxl/core/region.c:964 cxl_port_setup_targets() error: uninitialized symbol 'peiw'. drivers/cxl/core/region.c:964 cxl_port_setup_targets() error: uninitialized symbol 'eiw'. drivers/cxl/core/region.c:968 cxl_port_setup_targets() error: uninitialized symbol 'peiw'. drivers/cxl/core/region.c:969 cxl_port_setup_targets() error: uninitialized symbol 'peig'. drivers/cxl/core/region.c:1557 create_pmem_region_store() warn: unsigned 'rc' is never less than zero. > --- snip >
