On 24/06/2022 19:35, Bjorn Helgaas wrote: > In exynos_pcie_host_init() [1], we call: > > phy_reset(ep->phy); > phy_power_on(ep->phy); > phy_init(ep->phy); > > The phy_init() function comment [2] says it must be called before > phy_power_on(). Is exynos doing this backwards? Looks like. I don't have Exynos hardware with a PCI, so cannot test/fix/verify. Luckily for Exynos ;-) it's not alone in this pattern: drivers/net/ethernet/marvell/sky2.c drivers/usb/dwc2/platform.c > > Bjorn > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/controller/dwc/pci-exynos.c?id=v5.19-rc1#n252 > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-core.c?id=v5.19-rc1#n233 Best regards, Krzysztof
