The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'ret'. This was found by smatch: drivers/pci/endpoint/functions/pci-epf-vntb.c:1317 epf_ntb_bind() warn: missing error code 'ret'. Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index ebf7e243eefa..8791638b9f48 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -1314,6 +1314,7 @@ static int epf_ntb_bind(struct pci_epf *epf) if (pci_register_driver(&vntb_pci_driver)) { dev_err(dev, "failure register vntb pci driver\n"); + ret = -EINVAL; goto err_bar_alloc; } -- 2.20.1.7.g153144c