On Fri, Jun 10, 2022 at 11:25:32AM +0300, Serge Semin wrote: > The whole switch-case-logic implemented in the DWC PCIe RC/EP probe > procedure doesn't seem well thought through. First of all the ret variable > is unused in the EP-case and is only partly involved in the RC-case of the > switch-case statement, which unnecessary complicates the code. Secondly > the probe method will return zero if an unknown mode is detected. That is > improbable situation since the OF-device data is initialized only with > valid modes, but such code is still wrong at least from maintainability > point of view. So let's convert the switch-case part of the probe function > to being more coherent. We suggest to use the local ret variable to > preserve the status of the case-clauses and return its value from the > probe procedure after the work is done. > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > --- > drivers/pci/controller/dwc/pcie-designware-plat.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
