On Mon, Jun 13, 2022 at 04:55:36PM +0800, Richard Zhu wrote:
> The driver should undo any enables it did itself. The regulator disable
> shouldn't be basing decisions on regulator_is_enabled().
>
> Move the regulator_disable to the suspend function, turn off regulator
> when the system is in suspend mode.
According to the documentation:
vpcie-supply:
description: Should specify the regulator in charge of PCIe port power.
The regulator will be enabled when initializing the PCIe host and
disabled either as part of the init process or when shutting down
the host (optional required).
Is this really what we want to do (remove power in suspend, enable
it on resume)? On our boards this powers a PCIe device connected to the host
port, that sound fair according to the binding documentation for it.
Am I wrong?
We do have issues with PCIe not working anymore after suspend/resume,
wondering (I did not have time to properly dig into it) if this is the
root cause.
Francesco
