On Thu, Jun 02, 2022 at 03:11:33PM -0500, Mario Limonciello wrote: > Add support for SMN communication on Family 19h Model 70h. > > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> > --- > arch/x86/kernel/amd_nb.c | 4 ++++ > include/linux/pci_ids.h | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/arch/x86/kernel/amd_nb.c b/arch/x86/kernel/amd_nb.c > index 60c7bd525237..15295f5d9aca 100644 > --- a/arch/x86/kernel/amd_nb.c > +++ b/arch/x86/kernel/amd_nb.c > @@ -32,6 +32,8 @@ > #define PCI_DEVICE_ID_AMD_19H_M40H_ROOT 0x14b5 > #define PCI_DEVICE_ID_AMD_19H_M40H_DF_F4 0x167d > #define PCI_DEVICE_ID_AMD_19H_M50H_DF_F4 0x166e > +#define PCI_DEVICE_ID_AMD_19H_M70H_ROOT 0x14e8 > +#define PCI_DEVICE_ID_AMD_19H_M70H_DF_F4 0x14f4 > The IDs are correct. But can you please group the "ROOT" IDs together including PCI_DEVICE_ID_AMD_19H_M40H_ROOT? Otherwise, looks good to me. Reviewed-by: Yazen Ghannam <yazen.ghannam@xxxxxxx> Thanks, Yazen