On Thu, Jun 09, 2022 at 02:14:32AM +0800, kernel test robot wrote: > Hi Rajvi, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on helgaas-pci/next] > [also build test ERROR on linus/master v5.19-rc1 next-20220608] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] I'll wait for the v7 to fix the warning. At the same time, please capitalize the subject lines per convention, and also the "set ptm_enabled" in 2/2 commit log. > url: https://github.com/intel-lab-lkp/linux/commits/Rajvi-Jingar/PCI-PM-refactor-pci_pm_suspend_noirq/20220608-092412 > base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next > config: i386-randconfig-a001 (https://download.01.org/0day-ci/archive/20220609/202206090155.uxFOFYd0-lkp@xxxxxxxxx/config) > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 > reproduce (this is a W=1 build): > # https://github.com/intel-lab-lkp/linux/commit/1bf4649d5fa01aa9d1ce606461791344adfaa2ab > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Rajvi-Jingar/PCI-PM-refactor-pci_pm_suspend_noirq/20220608-092412 > git checkout 1bf4649d5fa01aa9d1ce606461791344adfaa2ab > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All errors (new ones prefixed by >>): > > drivers/pci/pci.c: In function 'pci_save_state': > >> drivers/pci/pci.c:1677:18: error: 'struct pci_dev' has no member named 'ptm_enabled'; did you mean 'ats_enabled'? > 1677 | if (dev->ptm_enabled) > | ^~~~~~~~~~~ > | ats_enabled > > > vim +1677 drivers/pci/pci.c > > 1644 > 1645 /** > 1646 * pci_save_state - save the PCI configuration space of a device before > 1647 * suspending > 1648 * @dev: PCI device that we're dealing with > 1649 */ > 1650 int pci_save_state(struct pci_dev *dev) > 1651 { > 1652 int i; > 1653 /* XXX: 100% dword access ok here? */ > 1654 for (i = 0; i < 16; i++) { > 1655 pci_read_config_dword(dev, i * 4, &dev->saved_config_space[i]); > 1656 pci_dbg(dev, "saving config space at offset %#x (reading %#x)\n", > 1657 i * 4, dev->saved_config_space[i]); > 1658 } > 1659 dev->state_saved = true; > 1660 > 1661 i = pci_save_pcie_state(dev); > 1662 if (i != 0) > 1663 return i; > 1664 > 1665 i = pci_save_pcix_state(dev); > 1666 if (i != 0) > 1667 return i; > 1668 > 1669 pci_save_ltr_state(dev); > 1670 pci_save_dpc_state(dev); > 1671 pci_save_aer_state(dev); > 1672 /* > 1673 * PCI PM core disables PTM during suspend and saves PTM state before > 1674 * that to be able to restore the ptm state restored later. So PCI core > 1675 * needs this check to avoid double save. > 1676 */ > > 1677 if (dev->ptm_enabled) > 1678 pci_save_ptm_state(dev); > 1679 return pci_save_vc_state(dev); > 1680 } > 1681 EXPORT_SYMBOL(pci_save_state); > 1682 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp
