Re: [PATCH] msi: Disable msi interrupts when we initialize a pci device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 17 Oct 2011 11:46:06 -0700
ebiederm@xxxxxxxxxxxx (Eric W. Biederman) wrote:

> 
> I traced a nasty kexec on panic boot failure to the fact that we had
> screaming msi interrupts and we were not disabling the msi messages at
> kernel startup.  The booting kernel had not enabled those interupts so
> was not prepared to handle them.
> 
> I can see no reason why we would ever want to leave the msi interrupts
> enabled at boot if something else has enabled those interrupts.  The pci
> spec specifies that msi interrupts should be off by default.  Drivers
> are expected to enable the msi interrupts if they want to use them.  Our
> interrupt handling code reprograms the interrupt handlers at boot and
> will not be be able to do anything useful with an unexpected interrupt.
> 
> This patch applies cleanly all of the way back to 2.6.32 where I noticed
> the problem.
> 
> Cc: stable@xxxxxxxxxx
> 

Applied to -next because I'm a chicken.

-- 
Jesse Barnes, Intel Open Source Technology Center

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux