Hi Dmitry, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.18] [also build test ERROR on next-20220603] [cannot apply to clk/clk-next helgaas-pci/next agross-msm/qcom/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/PCI-qcom-Rework-pipe_clk-pipe_clk_src-handling/20220605-164136 base: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f config: mips-randconfig-r005-20220605 (https://download.01.org/0day-ci/archive/20220605/202206052344.Lkv2vI5x-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 416a5080d89066029f9889dc23f94de47c2fa895) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/4fbc2ca1313223feb409121fa1028557f72a310b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Dmitry-Baryshkov/PCI-qcom-Rework-pipe_clk-pipe_clk_src-handling/20220605-164136 git checkout 4fbc2ca1313223feb409121fa1028557f72a310b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/clk/qcom/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/clk/qcom/clk-regmap-phy-mux.c:30:8: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] val = FIELD_GET(PHY_MUX_MASK, val); ^ >> drivers/clk/qcom/clk-regmap-phy-mux.c:44:7: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] FIELD_PREP(PHY_MUX_MASK, PHY_MUX_PHY_SRC)); ^ drivers/clk/qcom/clk-regmap-phy-mux.c:54:7: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] FIELD_PREP(PHY_MUX_MASK, PHY_MUX_REF_SRC)); ^ 3 errors generated. vim +/FIELD_GET +30 drivers/clk/qcom/clk-regmap-phy-mux.c 22 23 static int phy_mux_is_enabled(struct clk_hw *hw) 24 { 25 struct clk_regmap *clkr = to_clk_regmap(hw); 26 struct clk_regmap_phy_mux *phy_mux = to_clk_regmap_phy_mux(clkr); 27 unsigned int val; 28 29 regmap_read(clkr->regmap, phy_mux->reg, &val); > 30 val = FIELD_GET(PHY_MUX_MASK, val); 31 32 WARN_ON(val != PHY_MUX_PHY_SRC && val != PHY_MUX_REF_SRC); 33 34 return val == PHY_MUX_PHY_SRC; 35 } 36 37 static int phy_mux_enable(struct clk_hw *hw) 38 { 39 struct clk_regmap *clkr = to_clk_regmap(hw); 40 struct clk_regmap_phy_mux *phy_mux = to_clk_regmap_phy_mux(clkr); 41 42 return regmap_update_bits(clkr->regmap, phy_mux->reg, 43 PHY_MUX_MASK, > 44 FIELD_PREP(PHY_MUX_MASK, PHY_MUX_PHY_SRC)); 45 } 46 -- 0-DAY CI Kernel Test Service https://01.org/lkp