Re: [PATCH V13 1/6] PCI: loongson: Use generic 8/16/32-bit config ops on LS2K/LS7A

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Bjorn,

On Wed, Jun 1, 2022 at 10:08 AM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
>
> On Sat, Apr 30, 2022 at 04:48:41PM +0800, Huacai Chen wrote:
> > LS2K/LS7A support 8/16/32-bits PCI config access operations via CFG1, so
> > we can disable CFG0 for them and safely use pci_generic_config_read()/
> > pci_generic_config_write() instead of pci_generic_config_read32()/pci_
> > generic_config_write32().
> >
> > Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
>
> After removing cast below,
OK, thanks.

Huacai
>
> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>
> > @@ -193,20 +220,20 @@ static int loongson_pci_probe(struct platform_device *pdev)
> >
> >       priv = pci_host_bridge_priv(bridge);
> >       priv->pdev = pdev;
> > -     priv->flags = (unsigned long)of_device_get_match_data(dev);
> > +     priv->data = (struct loongson_pci_data *)of_device_get_match_data(dev);
>
> No cast needed.



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux