On Tue, May 31, 2022 at 10:07 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > > On Tue, May 31, 2022 at 6:01 PM Huacai Chen <chenhuacai@xxxxxxxxxx> wrote: > > On Tue, May 31, 2022 at 7:15 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > > > On Tue, May 31, 2022 at 10:17 AM Huacai Chen <chenhuacai@xxxxxxxxxx> wrote: > > > https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/log/?h=loongarch-next > > has been updated. Now this branch droped irqchip drivers and pci > > drivers. But the existing irqchip drivers need some small adjustment > > to avoid build errors [1], and I hope Marc can give an Acked-by. > > Ok, glad you got that working. > >From an allmodconfig build, I see two more things that could be addressed first: drivers/pci/probe.c: In function 'pci_scan_bridge_extend': drivers/pci/probe.c:1298:44: error: implicit declaration of function 'pcibios_assign_all_busses' [-Werror=implicit-function-declaration] 1298 | if ((secondary || subordinate) && !pcibios_assign_all_busses() && | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/pci/setup-res.c: In function '__pci_assign_resource': drivers/pci/setup-res.c:257:46: error: 'PCIBIOS_MIN_IO' undeclared (first use in this function) 257 | min = (res->flags & IORESOURCE_IO) ? PCIBIOS_MIN_IO : PCIBIOS_MIN_MEM; | ^~~~~~~~~~~~~~ drivers/pci/setup-res.c:257:46: note: each undeclared identifier is reported only once for each function it appears in drivers/pci/setup-res.c:257:63: error: 'PCIBIOS_MIN_MEM' undeclared (first use in this function) 257 | min = (res->flags & IORESOURCE_IO) ? PCIBIOS_MIN_IO : PCIBIOS_MIN_MEM; | ^~~~~~~~~~~~~~~ drivers/pci/quirks.c: In function 'quirk_isa_dma_hangs': drivers/pci/quirks.c:252:14: error: 'isa_dma_bridge_buggy' undeclared (first use in this function) 252 | if (!isa_dma_bridge_buggy) { | ^~~~~~~~~~~~~~~~~~~~ I think you accidentally dropped the asm/pci.h header, so adding that one back should make it build again. lib/test_printf.c:215: warning: "PTR" redefined 215 | #define PTR ((void *)0xffff0123456789abUL) | In file included from /git/arm-soc/arch/loongarch/include/asm/vdso/vdso.h:9, from /git/arm-soc/arch/loongarch/include/asm/vdso/gettimeofday.h:13, from /git/arm-soc/include/vdso/datapage.h:137, from /git/arm-soc/arch/loongarch/include/asm/vdso.h:11, from /git/arm-soc/arch/loongarch/include/asm/elf.h:13, from /git/arm-soc/include/linux/elf.h:6, from /git/arm-soc/include/linux/module.h:19, from /git/arm-soc/lib/test_printf.c:10: /git/arm-soc/arch/loongarch/include/asm/asm.h:182: note: this is the location of the previous definition 182 | #define PTR .dword | Not sure what the best fix is for this, maybe the contents of asm/asm.h could just be hidden in an "#idef __ASSEMBLER__" check. This can be a follow-up patch when the branch is merged. Arnd
