On Thu, 26 May 2022 15:38:01 -0500 Rob Herring <robh@xxxxxxxxxx> wrote: > On Tue, May 24, 2022 at 03:28:26PM +0200, Marek Behún wrote: > > From: Pali Rohár <pali@xxxxxxxxxx> > > > > Aardvark controller supports Advanced Error Reporting configuration > > registers. > > > > Export these registers on the emulated root bridge via the new .read_ext > > and .write_ext methods. > > > > Note that in the Advanced Error Reporting Capability header the offset > > to the next Extended Capability header is set, but it is not documented > > in Armada 3700 Functional Specification. Since this change adds support > > only for Advanced Error Reporting, explicitly clear PCI_EXT_CAP_NEXT > > bits in AER capability header. > > > > Now the pcieport driver correctly detects AER support and allows PCIe > > AER driver to start receiving ERR interrupts. Kernel log now says: > > > > [ 4.358401] pcieport 0000:00:00.0: AER: enabled with IRQ 52 > > > > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx> > > Signed-off-by: Marek Behún <kabel@xxxxxxxxxx> > > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> > > Did you mean Reviewed-by? Signed-off-by is only correct if Lorenzo > applied or rewrote these. If he applied them, then Bjorn will pick them > up. Hmm. Well, Lorenzo applied the subset I am sending (patches 3 and 5) to his tree, with SOB, meaning to send it to Bjorn [1]. Then we discovered that patch 4 is also required for the _SHIFT macros, which was discussed previously that we want to avoid those, and use FIELD_PREP() / FIELD_GET() instead [2]. So I updated the second patch to use FIELD_PREP() / FIELD_GET() instead of the _SHIFT macros. I guess this version isn't SOB by Lorenzo, but the first version was... I should probably change it to Reviewed-by for both patches anyway, right? Marek [1] https://lore.kernel.org/linux-arm-kernel/165288925279.7950.90687082853412954.b4-ty@xxxxxxx/ [2] https://lore.kernel.org/linux-arm-kernel/20220518202729.GA4606@bhelgaas/
