On Tue, May 24, 2022 at 7:56 PM Cyril Brulebois <kibi@xxxxxxxxxx> wrote: > > Hi Jim, > > Jim Quinlan <jim2101024@xxxxxxxxx> (2022-05-24): > > Yes. One repo did not have this node (Cyril/debina?), one did > > (https://github.com/raspberrypi/firmware/tree/master/boot). > > Of course there is nothing wrong with omitting the node; it should > > have pcie linkup regardless. > > I work/debug stuff on Debian systems, but Debian's just shipping what's > in mainline. Raspberry people maintain their own vendor DTBs. > > > Unless you object, I plan on sending you a v2 of my regression fix > > which will correct the commit message, change the "if (busno == 1)" > > conditional to only guard the pcie linkup call, and add further > > comments. > > > > I have noted and will also address your other concerns and suggestions > > in a future patchset as I think it is best that I get my hands on a > > CM4 board before I submit any more changes. > > For the record, I'm still happy to be cc'ed so that I spend time testing > further patches, be it the short-term regression fix (for inclusion in > master, but also checking it fixes linux-5.17.y and now linux-5.18.y, > if stable maintainers would welcome the extra testing), or the future > patchset. > > I can't guarantee you'll have an answer in a few hours like that > happened during the past few days (during which I prioritized testing > over anything else so as not to be a blocker in case it could be > squeezed into v5.18). But I'm still willing to allocate some time to > make sure the CM4 keeps working, even if you don't get your hands on > such systems right away. I really appreciate the help, thank you. We have ordered a CM4 and I will be testing on it prior to sending pullreqs. Regards, Jim Quinlan Broadcom ST > > > Cheers, > -- > Cyril Brulebois (kibi@xxxxxxxxxx) <https://debamax.com/> > D-I release manager -- Release team member -- Freelance Consultant
