On Fri, May 20, 2022 at 09:31:07PM +0300, Dmitry Baryshkov wrote: > I have replied with my Tested-by to the patch at [2], which has landed > in the linux-next as the commit 20f1bfb8dd62 ("PCI: qcom: > Add support for handling MSIs from 8 endpoints"). However lately I > noticed that during the tests I still had 'pcie_pme=nomsi', so the > device was not forced to use higher MSI vectors. > > After removing this option I noticed that hight MSI vectors are not > delivered on tested platforms. After additional research I stumbled upon > a patch in msm-4.14 ([1]), which describes that each group of MSI > vectors is mapped to the separate interrupt. Implement corresponding > mapping. > > The first patch in the series is a revert of [2] (landed in pci-next). > Either both patches should be applied or both should be dropped. > > Patchseries dependecies: [3] (for the schema change). > > Changes since v10: > - Remove has_split_msi_irqs flag. Trust DT and use split MSI IRQs if > they are described in the DT. This removes the need for the > pcie-qcom.c changes (everything is handled by the core (suggested by > Johan). You could also mention the rebase and fixed warnings with less than eight msi. > [1] https://git.codelinaro.org/clo/la/kernel/msm-4.14/-/commit/671a3d5f129f4bfe477152292ada2194c8440d22 > [2] https://lore.kernel.org/linux-arm-msm/20211214101319.25258-1-manivannan.sadhasivam@xxxxxxxxxx/ > [3] https://lore.kernel.org/linux-arm-msm/20220422211002.2012070-1-dmitry.baryshkov@xxxxxxxxxx/ > > > Dmitry Baryshkov (7): > PCI: dwc: Convert msi_irq to the array > PCI: dwc: split MSI IRQ parsing/allocation to a separate function > PCI: dwc: Handle MSIs routed to multiple GIC interrupts > PCI: dwc: Implement special ISR handler for split MSI IRQ setup > dt-bindings: PCI: qcom: Support additional MSI interrupts > arm64: dts: qcom: sm8250: provide additional MSI interrupts > dt-bindings: mfd: qcom,qca639x: add binding for QCA639x defvice Looks like you used the wrong offsets from HEAD or something when generating the series as the first two patches ([1] above, which is not yet in linux-next, and the dw_pcie_free_msi() fix) are now missing and the last patch is new and unrelated. Johan