Quoting Dmitry Baryshkov (2022-05-19 04:16:19) > On 18/05/2022 20:58, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-05-13 10:53:36) > >> diff --git a/drivers/clk/qcom/clk-regmap-phy-mux.c b/drivers/clk/qcom/clk-regmap-phy-mux.c > >> new file mode 100644 > >> index 000000000000..d7a45f7fa1aa > >> --- /dev/null > >> +++ b/drivers/clk/qcom/clk-regmap-phy-mux.c [...] > >> + > >> +#include "clk-regmap-phy-mux.h" > > > > Same for clk-regmap.h, avoid include hell. > > I couldn't catch this comment. I think we need clk-regmap.h in > clk-regmap-phy-mux.h as clk_regmap is a part of defined structure. > Don't rely on implicit includes. It makes changing header files error prone. Also, please trim replies.