On 04.05.22 19:06, Bjorn Helgaas wrote:
On Wed, May 04, 2022 at 12:05:55PM +0200, Felix Fietkau wrote:
This allows it to coexist with the other mtk pcie driver in the same kernel
I assume this is a v3 of [1]. Please:
Thanks, I wasn't aware of that patch.
- Follow the subject line capitalization convention, i.e.,
"PCI: mediatek-gen3: Change ..."
- Expand the commit log to say why this is important. From a C
language level, using the same "mtk-pcie" string in both drivers
is no problem. So please mention where it *is* a problem, e.g.,
if it's a problem with modprobe or similar, say that. Or if it's
to make log messages in dmesg have different driver names, say
that.The reason is the fact that driver_register will refuse to register a
driver if one with the same name has already been registered.
- s/pcie/PCIe/ in commit log and other English text.
- Add a period at the end of the commit log sentence.
[1] https://lore.kernel.org/r/20220422070908.14043-1-jianjun.wang@xxxxxxxxxxxx
Will take care of this and send an updated version as v3.
- Felix
