On Mon, 31 Oct 2011 10:31:01 -0700 Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote: > On 10/31/2011 10:24 AM, Jesse Barnes wrote: > > On Sun, 30 Oct 2011 16:35:08 +0100 > > Joerg Roedel <joerg.roedel@xxxxxxx> wrote: > > > >> The ats and sroiv members of 'struct pci_dev' are required > >> for the ATS code already, even without IOV support compiled > >> in. So depend on ATS here. This is fine with PCI_IOV too > >> because it selects PCI_ATS. Also the prototypes for ATS > >> need to be available for PCI_ATS. > > > > Applied these two, thanks Joerg. > > Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx> > > However, for linux-next (where the module-split tree is being worked), > drivers/pci/ats.c also needs to include <linux/export.h>. Patch is below. > > --- > From: Randy Dunlap <rdunlap@xxxxxxxxxxxx> > > pci/ats.c needs to include <linux/export.h> (in linux-next only for now) > to fix build warnings and to make exported symbols available: > > drivers/pci/ats.c:96:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' > drivers/pci/ats.c:127:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' > etc. > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx> > --- > drivers/pci/ats.c | 1 + > 1 file changed, 1 insertion(+) > > --- next-2011-1025.orig/drivers/pci/ats.c > +++ next-2011-1025/drivers/pci/ats.c > @@ -10,6 +10,7 @@ > * PASID support added by Joerg Roedel <joerg.roedel@xxxxxxx> > */ > > +#include <linux/export.h> > #include <linux/pci-ats.h> > #include <linux/pci.h> > > Appiled, thanks Randy. -- Jesse Barnes, Intel Open Source Technology Center
Attachment:
signature.asc
Description: PGP signature
