On 22-04-22, 08:57, Wangseok Lee wrote: > > On 18/04/2022 09:20, Wangseok Lee wrote: > > Maybe, quite probably. The reluctance to extend any existing code makes > > me doubting this, but I admit that there are many differences. > > > >> For these reasons, my opinion is that better to create > >> a phy, controller both driver with a new file. > >> Please let me know your opinion. > > > > At the end it's mostly the decision of PCIe and phy subsystem > > maintainers whether they want to have separate drivers for DWC PCIe > > blocks in ARMv8 Samsung SoCs. > > > > In any case, the driver code looks like copied-pasted from some vendor > > sources, so you need to bring it to shape. I think havong a common driver helps everyone, many vendors do that already. If you have a technical issue of adding and maintaining a common driver upstream we would be eager to understand and help with that... -- ~Vinod
