On Thu, Apr 21, 2022 at 01:40:02PM -0700, Kenneth R. Crudup wrote: > On Thu, 21 Apr 2022, Kai-Heng Feng wrote: > > > I went through the whole discussion again, maybe Kenneth's case is > > also the result of pcie_aspm_pm_state_change()? > > > Since Kenneth is using TLP to switch ASPM between performance and > > powersaving/powersupersaving, that means 'aspm_disabled' is false. > > Hence the KOXIA NVMe stops working post suspend and Realtek card > > reader toggles L1ss post hibernation. > > > Kenneth, can you please see if removing pcie_aspm_pm_state_change() > > from pci_raw_set_power_state() helps? > > Anyway, this can be easier to spot if dmesg was attached. > > Well, I haven't had an issue with resume/return from hibernate for quite some > time, and the patch I'd reported a long time ago is now in the Linus' master > I've been running. I believe a BIOS change from Dell fixed it up for me. Which patch are you referring to? Vidya's original patch [1] is not upstream, at least AFAIK. Well, it *was* merged as 4257f7e008ea [2] in v5.11-rc1, but then reverted by 40fb68c7725a [3] in v5.11-rc7. [1] https://lore.kernel.org/r/20220201123536.12962-1-vidyas@xxxxxxxxxx [2] https://git.kernel.org/linus/4257f7e008ea [3] https://git.kernel.org/linus/40fb68c7725a
