On Wed, Apr 20, 2022 at 08:27:05AM -0500, Rob Herring wrote: > On Wed, Apr 20, 2022 at 08:58:32AM +0200, Uwe Kleine-König wrote: > > If the driver is configured as a module (after allowing this by changing > > PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon makes the > > compiler very unhappy. While there isn't a real problem as > > MODULE_DEVICE_TABLE always evaluates to nothing for a built-in driver, > > do it right for consistency with other drivers. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > --- > > Hello, > > > > I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST (and > > some others) only bool. With this patch applied the driver compiles just > > fine with PCIE_MICROCHIP_HOST=m. > > Historical copy-n-paste. For the record: I sent a patch to allow PCIE_MICROCHIP_HOST=m: https://lore.kernel.org/linux-pci/20220420093449.38054-1-u.kleine-koenig@xxxxxxxxxxxxxx Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
