On Wed, Apr 20, 2022 at 09:59:52AM +0800, Yinjun Zhang wrote: > On Wed, Apr 20, 2022 at 12:00:05AM +0200, Andrew Lunn wrote: > > On Tue, Apr 19, 2022 at 06:02:48PM +0800, Yinjun Zhang wrote: > > > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > > Cc: linux-pci@xxxxxxxxxxxxxxx > > > Signed-off-by: Yinjun Zhang <yinjun.zhang@xxxxxxxxxxxx> > > > Signed-off-by: Simon Horman <simon.horman@xxxxxxxxxxxx> > > > --- > > > include/linux/pci_ids.h | 2 ++ > > > > The very top of this file says: > > > > * Do not add new entries to this file unless the definitions > > * are shared between multiple drivers. > > > > Please add to the commit messages the two or more drivers which share > > this definition. > > It will be used by ethernet and infiniband driver as we can see now, > I'll update the commit message if you think it's a good practice. Are you going to submit completely separated infiniband driver that has PCI logic in drivers/infiniband without connection todrivers/net/ethernet ...? If yes, it is very uncommon in infiniband world. I would like to see this PCI patch submitted when it is actually used. Thanks > > > > > Thanks > > > > Andrew
