On Wed, Apr 13, 2022 at 09:37:28AM -0400, Peter Geis wrote: > The snps,dw-pcie binds to a standalone driver. > It is not fully compatible with the Rockchip implementation and causes a > hang if it binds to the device. > > Remove this binding as a valid fallback. > > Signed-off-by: Peter Geis <pgwipeout@xxxxxxxxx> > --- > Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > index 142bbe577763..8dc11fed8a3c 100644 > --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > @@ -32,7 +32,6 @@ properties: > compatible: > items: > - const: rockchip,rk3568-pcie > - - const: snps,dw-pcie With this, you no longer need 'select' so please drop it too. > > reg: > items: > @@ -110,7 +109,7 @@ examples: > #size-cells = <2>; > > pcie3x2: pcie@fe280000 { > - compatible = "rockchip,rk3568-pcie", "snps,dw-pcie"; > + compatible = "rockchip,rk3568-pcie"; > reg = <0x3 0xc0800000 0x0 0x390000>, > <0x0 0xfe280000 0x0 0x10000>, > <0x3 0x80000000 0x0 0x100000>; > -- > 2.25.1 > >