+ ath11k Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> writes: > +Kalle, linux-wireless > > On Tue, Mar 08, 2022 at 12:25:06AM +0530, Prasad Malisetty wrote: >> Add suspend_noirq and resume_noirq callbacks to handle >> system suspend and resume in dwc PCIe controller driver. >> >> When system suspends, send PME turnoff message to enter >> link into L2 state. Along with powerdown the PHY, disable >> pipe clock, switch gcc_pcie_1_pipe_clk_src to XO if mux is >> supported and disable the pcie clocks, regulators. >> > > Kalle, is this behaviour appropriate for WLAN devices as well? The devices > will be put into poweroff state (assuming no Vaux provided in D3cold) during > system suspend. ath11k leaves the firmware running during suspend. I don't fully understand what the patch is doing, but if it cuts the power from the WLAN chip during suspend that will break ath11k. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches