On Sat, Apr 02, 2022 at 04:48:45PM +0200, Lukas Wunner wrote: > On Thu, Mar 31, 2022 at 08:19:56AM -0700, Ira Weiny wrote: > > On Wed, Mar 30, 2022 at 10:50:31PM -0700, Christoph Hellwig wrote: > > > On Wed, Mar 30, 2022 at 04:59:13PM -0700, ira.weiny@xxxxxxxxx wrote: > > > > Introduced in a PCI v6.0[1], DOE provides a config space based mailbox > > > > with standard protocol discovery. Each mailbox is accessed through a > > > > DOE Extended Capability. > > > > > > I really don't think this should be built unconditionally and bloat > > > every single kernel built with PCI support. > > > > I can add a Kconfig. > > Ideally, that config option should live in the pcie/ subdirectory, > i.e. in drivers/pci/pcie/Kconfig, alongside drivers/pci/pcie/doe.c, > as we try to consolidate PCIe-specific features there and reserve > core code in drivers/pci/*.c for functionality that also applies > to Conventional PCI. Thanks for letting me know about this direction. I was unaware of this. I'll move the file no problem, thanks, Ira > > Thanks, > > Lukas