On Mon, Apr 04, 2022 at 08:44:41PM +0100, Guillaume Tucker wrote:
> On 29/03/2022 19:44, Guillaume Tucker wrote:
> > On 28/03/2022 13:54, Hans de Goede wrote:
> >> On 3/24/22 23:19, Mark Brown wrote:
> >>> On Thu, Mar 24, 2022 at 09:34:30PM +0100, Hans de Goede wrote:
> >> Ok, Guillaume, can you try a kernel with commit 5949965ec9340cfc0e65f7d8a576b660b26e2535
> >> ("x86/PCI: Preserve host bridge windows completely covered by E820") + the
> >> attached patch added on top a try on the asus-C523NA-A20057-coral machine please
> >> and see if that makes it boot again ?
> >
> > Sorry I've been busy with a conference. Sure, will put that
> > through KernelCI tomorrow and let you know the outcome.
>
> Well the issue seems to have been fixed on mainline, unless it's
> intermittent. In any case, next-20220404 is booting fine:
>
> https://linux.kernelci.org/test/plan/id/624aed811a5acd09adae071e/
>
> Last time it was seen to fail was next-20220330:
>
> https://linux.kernelci.org/test/plan/id/62442f68e30d6f89a4ae06b7/
This is because I dropped 5949965ec934 ("x86/PCI: Preserve host bridge
windows completely covered by E820") from the PCI tree starting with
next-20220401 because it causes the regression. So I expect
next-20220404 to boot fine (next-20220401 should boot fine as well; I
don't know whether that was tested).
The gory details:
20220330 should fail; it includes:
5949965ec934 ("x86/PCI: Preserve host bridge windows completely covered by E820")
d13f73e9108a ("x86/PCI: Log host bridge window clipping for E820 regions")
9c253994c5ba ("x86/PCI: Eliminate remove_e820_regions() common subexpressions")
ffb217a13a2e ("Linux 5.17-rc7")
20220331 should fail; it includes:
18146f25ac66 ("PCI: hv: Remove unused hv_set_msi_entry_from_desc()")
5949965ec934 ("x86/PCI: Preserve host bridge windows completely covered by E820")
d13f73e9108a ("x86/PCI: Log host bridge window clipping for E820 regions")
9c253994c5ba ("x86/PCI: Eliminate remove_e820_regions() common subexpressions")
ffb217a13a2e ("Linux 5.17-rc7")
20220401 should boot; it includes:
1c6cec4ab487 ("x86/PCI: Log host bridge window clipping for E820 regions")
b2922e67d233 ("x86/PCI: Eliminate remove_e820_regions() common subexpressions")
22ef7ee3eeb2 ("PCI: hv: Remove unused hv_set_msi_entry_from_desc()")
148a65047695 ("Merge tag 'pci-v5.18-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci")
20220404 should boot; it includes:
22ef7ee3eeb2 ("PCI: hv: Remove unused hv_set_msi_entry_from_desc()")
148a65047695 ("Merge tag 'pci-v5.18-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci")
> Ironically, the KernelCI staging linux-next job with the patches
> mentioned in your previous email applied is now failing:
>
> https://staging.kernelci.org/test/plan/id/624b2d3b923f532dc305f4c7/
This says we tested commit 1aceacc82d3f, which I guess is the
staging-next-20220404.1 tag at https://github.com/kernelci/linux.git.
It took me a while to find the commit history, but
https://github.com/kernelci/linux/commits/1aceacc82d3f says this
includes:
0a0c05a90278 x86/PCI: Limit "e820 entry fully covers window" check to non ISA MMIO
b5fd57109d22 x86/PCI: Preserve host bridge windows completely covered by E820
So the proposed fix (0a0c05a90278) apparently didn't work.
Bjorn
