On Thu, Mar 24, 2022 at 04:37:26AM +0300, Serge Semin wrote: > There is no point in having an enumeration declared in the driver for the > PCIe end-point. First of all it's redundant since the driver already has a > set of macro declared which describe the available in/out iATU types, thus > having an addition abstraction just needlessly complicates the code. > Secondly checking the passed iATU type for validity within a single driver > is pointless since the driver is supposed to be consistent by its nature. > Finally the outbound iATU type isn't encoded by the denoted enumeration, > thus giving a false impression that the in and out iATU types are > unrelated while they are the same. So to speak let's drop the redundant > dw_pcie_as_type enumeration replacing it with the direct iATU type usage. > > While at it, since we are touching the iATU inbound regions config methods > anyway, let's fix the arguments order so the type would be followed by the > address-related parameters. Thus the inbound and outbound iATU setup > methods will look alike. That shall improve the code readability a bit. > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > --- > .../pci/controller/dwc/pcie-designware-ep.c | 21 +++++------ > drivers/pci/controller/dwc/pcie-designware.c | 35 +++---------------- > drivers/pci/controller/dwc/pcie-designware.h | 9 +---- > 3 files changed, 15 insertions(+), 50 deletions(-) Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
