[PATCH v5 2/2] PCI / ACPI: Adjust comment about `HotPlugSupportInD3`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The comments in `acpi_pci_bridge_d3` make an assertion that all devices
behind a PCIe root port that supports D3 also support D3.  This was
pointed out however that it's no guarantee but rather a reasonable
assumption for the ecosystem used for Thunderbolt and USB4.

Update the comment to use weaker language and clarifying this is an
assumption.

Suggested-by: Bjorn Helgaas <helgaas@xxxxxxxxxx>
Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
---
v4->v5:
 * New patch

 drivers/pci/pci-acpi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index 91c165ea4346..4f12d4fca808 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -989,8 +989,8 @@ bool acpi_pci_bridge_d3(struct pci_dev *dev)
 	/*
 	 * The ACPI firmware will provide the device-specific properties through
 	 * _DSD configuration object. Look for the 'HotPlugSupportInD3' property
-	 * for the root port and if it is set we know the hierarchy behind it
-	 * supports D3 just fine.
+	 * for the root port and if it is set we make an assumption that the
+	 * hierarchy behind it supports D3 as well.
 	 */
 	rpdev = pcie_find_root_port(dev);
 	if (!rpdev)
-- 
2.34.1




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux