Re: [PATCH] PCI: mediatek: Update entries to distinguish MediaTek PCIe controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 26/03/22 04:27, Jianjun Wang ha scritto:
Add model numbers in Kconfig and update driver name in
pcie-mediatek-gen3.c to distinguish the MediaTek PCIe controllers.

Signed-off-by: Jianjun Wang <jianjun.wang@xxxxxxxxxxxx>
---
  drivers/pci/controller/Kconfig              | 11 +++++++----
  drivers/pci/controller/pcie-mediatek-gen3.c | 12 ++++++------
  2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 601f2531ee91..dd7a2caf8da9 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -237,8 +237,11 @@ config PCIE_MEDIATEK
  	depends on OF
  	depends on PCI_MSI_IRQ_DOMAIN
  	help
-	  Say Y here if you want to enable PCIe controller support on
-	  MediaTek SoCs.
+	  Adds support for PCIe MAC controller for MediaTek SoCs.
+
+	  The following SoCs are supported for this PCIe controller:
+	  MT2701 and MT7623 with no MSI supported.
+	  MT2712, MT7622 and MT7629 support up to 32 MSI interrupt numbers.
config PCIE_MEDIATEK_GEN3
  	tristate "MediaTek Gen3 PCIe controller"
@@ -250,8 +253,8 @@ config PCIE_MEDIATEK_GEN3
  	  and support up to 256 MSI interrupt numbers for
  	  multi-function devices.
- Say Y here if you want to enable Gen3 PCIe controller support on
-	  MediaTek SoCs.
+	  The following SoCs are supported for this PCIe controller:
+	  MT8192 and MT8195.

I agree with the pcie-mediatek-gen3 naming change, it's good to differentiate,
but I don't think that updating the Kconfig description is a good idea.

Everyone can get the list of supported SoCs by reading the dt-bindings for these
drivers, so it's unnecessary to make a list of SoCs in Kconfig... this is also
to avoid updating these entries everytime support for a new chip is added to the
gen3 (or the other) driver.

If nobody opposes to my proposal - please drop that description change.

Regards,
Angelo



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux