On Thu, Mar 24, 2022 at 04:25:18AM +0300, Serge Semin wrote: > There are two places in the DW PCIe controller driver, which omit the > trailing newlines in the log info and warn messages. Not having them there > will cause leaving the messages in the printk ring buffer until a next > '\n'-terminated message is printed (it will consequently cause the buffer > flush). As it isn't what the corresponding code implies let's add the > new-line characters in the messages. > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> Thanks, Mani > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 2 +- > drivers/pci/controller/dwc/pcie-designware.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index a048d88e0c30..8364ea234e88 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -657,7 +657,7 @@ void dw_pcie_setup_rc(struct pcie_port *pp) > } > > if (pci->num_ob_windows <= atu_idx) > - dev_warn(pci->dev, "Resources exceed number of ATU entries (%d)", > + dev_warn(pci->dev, "Resources exceed number of ATU entries (%d)\n", > pci->num_ob_windows); > } > > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c > index 9f4d2b44612b..3bd1cfd12148 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.c > +++ b/drivers/pci/controller/dwc/pcie-designware.c > @@ -706,7 +706,7 @@ void dw_pcie_iatu_detect(struct dw_pcie *pci) > dev_info(pci->dev, "iATU unroll: %s\n", pci->iatu_unroll_enabled ? > "enabled" : "disabled"); > > - dev_info(pci->dev, "Detected iATU regions: %u outbound, %u inbound", > + dev_info(pci->dev, "Detected iATU regions: %u outbound, %u inbound\n", > pci->num_ob_windows, pci->num_ib_windows); > } > > -- > 2.35.1 >
