On Thu, Mar 17, 2022 at 3:25 AM Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> wrote: > > On Tue, 15 Mar 2022 21:14:03 -0700 > Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > > > There is no need to carry the barno and the block offset through the > > stack, just convert them to a resource base immediately. > > > > Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> > > Other that this involving paths where we try to carry on after a broken > device is detected which I'd be far from confident are correct or regularly > tested, the patch looks fine. cxl_test covers some of these cases, but otherwise the failed state should be equivalent to the state after "cxl disable-memdev $memX" > Particular case that bothers me is undersized bars. Before this patch > those were (I think) an error that would fail probe. Are they still after > this patch? Yes, that check just moves to cxl_decode_regblock() directly. > > Assuming that part is fine. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> Thanks.
