When dma_mapping_error returns error because of no enough memory available, dw_pcie_host_init will return success, which will mislead the callers. Signed-off-by: zhangjianrong <zhangjianrong5@xxxxxxxxxx> Signed-off-by: zhangjiantao <water.zhangjiantao@xxxxxxxxxx> --- drivers/pci/controller/dwc/pcie-designware-host.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index f4755f3a03be..ac691d733848 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -393,6 +393,7 @@ int dw_pcie_host_init(struct pcie_port *pp) if (dma_mapping_error(pci->dev, pp->msi_data)) { dev_err(pci->dev, "Failed to map MSI data\n"); pp->msi_data = 0; + ret = -1; goto err_free_msi; } } -- 2.17.1