Hi Bjorn, On Wed, 2 Mar 2022 at 05:37, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > In subject, s/pcie/PCIe/ > > Since the subject already mentions "sm8150:", maybe the "for SM8150" > is superfluous? > > On Tue, Mar 01, 2022 at 12:55:10PM +0530, Bhupesh Sharma wrote: > > Add nodes for the two PCIe controllers founds on the > > SM8150 SoC. > > s/founds/found/ > > Rewrap to fill 75 columns. Sure, I will fix these in v3. > > + interrupt-map = <0 0 0 1 &intc 0 149 IRQ_TYPE_LEVEL_HIGH>, /* int_a */ > > + <0 0 0 2 &intc 0 150 IRQ_TYPE_LEVEL_HIGH>, /* int_b */ > > + <0 0 0 3 &intc 0 151 IRQ_TYPE_LEVEL_HIGH>, /* int_c */ > > + <0 0 0 4 &intc 0 152 IRQ_TYPE_LEVEL_HIGH>; /* int_d */ > > Personally I would use INTA, INTB, etc in the comments to match the > PCI spec usage, but grep says that's a minority view. Right, I see that most dts (especially the qcom ones) use this nomenclature (although I have no strong personal opinion about this). Regards, Bhupesh
