On Sat, Oct 08, 2011 at 08:59:28AM +0200, Benjamin Herrenschmidt wrote: > On Sat, 2011-10-08 at 07:25 +0800, Ram Pai wrote: > > On x86, the code anyway works the way you mention. It allocates space > > to the VF BARs, only if available and is non-conflicting. If it is > > unable to do so, sriov_init() and its friends don't do much. > > They already do too much (ie changing num VF, changing page size), > that's enough to break some drivers. num VFs are set so that VF BARs can be allocated a resource-size that is a multiple of num VFs. page size is set so that the VF BARs can be aligned on page size boundaries. Now none of them is required and can be postponed to a later time, if we know the BIOS/UEFI has done a excellent job allocating resources. Unfortunately that is not the case sometimes :( RP -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html