On Fri, Feb 25, 2022 at 06:22:16PM +0100, Marek Behún wrote: > On Fri, 25 Feb 2022 09:37:56 -0600 > Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > Yes, it's a mix. For some recent additions, I've resisted adding the > > _SHIFT macros on the theory that they clutter the file, they never > > change, and the main point of the #defines is readability and so > > grep/tags/etc can find things. > > > > There are a *few* users of FIELD_PREP() and FIELD_GET(): > > > > git grep -E "FIELD_(GET|PREP)\(PCI_EXP" > > > > and I'm inclined to go that direction in the future. What do you > > think? > > I am also pro that direction. > > Would you also like to convert current usages in the .c driver files? > > We can't remove the existing macros since they are in UAPI, but we can > convert drivers so that they don't use _SHIFT macros. Certainly not a high priority, but it actually looks like there aren't *that* many uses in drivers/pci/, so I'd be OK with converting them. Bjorn
