On Thu, Feb 10, 2022 at 09:00:50AM +0100, Francesco Dolcini wrote: > Hello Lorenzo, > just a gently ping on this patch. > > Francesco > > On Mon, Jan 31, 2022 at 08:52:35AM +0100, Francesco Dolcini wrote: > > From: Jason Liu <jason.hui.liu@xxxxxxx> > > > > The driver install one hook to handle the external abort, but issue > > is that if the abort introduced from user space code, the following > > code unsigned long instr = *(unsigned long *)pc; which will created > > another data-abort(page domain fault) if CONFIG_CPU_SW_DOMAIN_PAN. > > > > The patch does not intent to use copy_from_user and then do the hack > > due to the security consideration. In fact, we can just return and > > report the external abort to user-space. Apologies for the delay in replying. This commit log should be rewritten - it is not clear. Isn't this an issue for all PCI host controllers that install a fault hook ? Is this referring to accessing config space directly from user space ? Can you explain the triggering conditions a bit better please ? Thanks, Lorenzo > > Link: https://lore.kernel.org/all/20220128082920.591115-1-francesco.dolcini@xxxxxxxxxxx > > Signed-off-by: Jason Liu <jason.hui.liu@xxxxxxx> > > Reviewed-by: Richard Zhu <hongxing.zhu@xxxxxxx> > > Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> > > Acked-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
