On Wed, Oct 5, 2011 at 12:01 AM, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote: > >> We just don't the hell know, do we? > > Well, we do with some confidence :-) Or rather what we do know is what > you have today in your tree is broken. You're missing the point. Repeat after me: late -rc series is not when we test these kinds of things. This point in time is when we *revert* commits that are broken. We fix them if there is absolutely no question about the fix, but that simply isn't true here. Even if the patches "improve" something, there is no way I hell that I believe that we suddenly don't need to worry about MPS any more. How hard is this to just understand? It's not about "we can improve things". It's about "it's f*%!ing late in the rc series, we're not dicking around any more!". So quite frankly, if you don't like the code now, send me a revert for all the mess. BUT DON'T ARGUE FOR CHANGES THAT AREN'T 100% ROCK SOLID. So the current situation is that MPS is simply *disabled*. All the crap code simply doesn't matter at all, because nobody will run it. Arguing that it is "broken" is stupid, because the only people that that brokenness would ever matter for are the people like you who are testing things out - not actual users. Comprende? Think of it like a stable kernel. We don't mess around with things that don't matter and nobody will hit. We don't do "development" in the late -rc, and yet that is what the MPS patches in question have been doing. IT IS TOO LATE FOR CRAP LIKE THAT. WE TURNED IT OFF. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html