On Mon, Feb 14, 2022 at 12:41:08PM +0100, Pali Rohár wrote: > Add following two new PCI class codes defines into pci_ids.h include file: > > PCI_CLASS_BRIDGE_PCI_NORMAL > PCI_CLASS_BRIDGE_PCI_SUBTRACTIVE > > And use these defines in all kernel code for describing PCI class codes for > normal and subtractive PCI bridges. Looks good; is this another case? drivers/pci/controller/pci-mvebu.c: dev_rev |= (PCI_CLASS_BRIDGE_PCI << 8) << 8; > static void quirk_sb1250_ht(struct pci_dev *dev) > { > - dev->class = PCI_CLASS_BRIDGE_PCI << 8; > + dev->class = PCI_CLASS_BRIDGE_PCI_NORMAL;