On Tue, Oct 04, 2011 at 08:54:19PM +0100, Ben Hutchings wrote:
> Using legacy interrupts and TLPs > 256 bytes on the SFC4000 (all
> revisions) may cause interrupt messages to be replayed. In some
> systems this results in a non-recoverable MCE. Early boards using the
> SFC4000 set the maximum payload size supported (MPSS) to 1024 bytes
> and we should override that.
>
> There are probably other devices with similar issues, so give this
> quirk a generic name.
>
Looks good to me. If my MPS mess hasn't pissed off Linus
sufficiently, you might try and get this into 3.1.
Acked-by: Jon Mason <mason@xxxxxxxx>
> Signed-off-by: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>
> ---
> drivers/pci/quirks.c | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 1196f61..6d7f670 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2822,6 +2822,17 @@ static void __devinit fixup_ti816x_class(struct pci_dev* dev)
> }
> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_TI, 0xb800, fixup_ti816x_class);
>
> +/* Some PCIe devices do not work reliably with the claimed maximum
> + * payload size supported.
> + */
> +static void __devinit fixup_mpss_256(struct pci_dev *dev)
> +{
> + dev->pcie_mpss = 1; /* 256 bytes */
> +}
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SOLARFLARE, 0x0703, fixup_mpss_256);
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SOLARFLARE, 0x6703, fixup_mpss_256);
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SOLARFLARE, 0x0710, fixup_mpss_256);
> +
> static void pci_do_fixups(struct pci_dev *dev, struct pci_fixup *f,
> struct pci_fixup *end)
> {
> --
> 1.7.4.4
>
>
> --
> Ben Hutchings, Staff Engineer, Solarflare
> Not speaking for my employer; that's the marketing department's job.
> They asked us to note that Solarflare product names are trademarked.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
