On Wed, Feb 9, 2022 at 8:58 AM Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> wrote: [..] > > It just seems an unnecessary hunk of code for the core to carry when > > it's trivial for a client of the core to do: > > > > task->private = &completion; > > task->end_task = complete_completion; > > submit_task() > > wait_for_completion(&completion); > > OK, we can move this to the callers though function obviously will > also need renaming - I guess to pci_doe_exchange() and now need to take a > task rather than the exchange. > > I personally slightly prefer the layered approach, but don't care that > strongly. Like I said, you and Ira are holding the pen, so if you decide to keep the layering, just document the ontology somewhere and I'll let it go.