On Thu, Feb 3, 2022 at 2:00 AM Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> wrote: > > Hi Dan, > > > > > diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h > > > > index b71d40b68ccd..0bbe394f2f26 100644 > > > > --- a/drivers/cxl/cxl.h > > > > +++ b/drivers/cxl/cxl.h > > > > @@ -323,6 +323,8 @@ struct cxl_port *devm_cxl_add_port(struct device *host, struct device *uport, > > > > struct cxl_port *find_cxl_root(struct device *dev); > > > > int devm_cxl_enumerate_ports(struct cxl_memdev *cxlmd); > > > > int cxl_bus_rescan(void); > > > > +struct cxl_port *cxl_mem_find_port(struct cxl_memdev *cxlmd); > > > > > > Should be in previous patch where the function is defined. > > > > Not really, because this patch is the first time it is used outside of > > core/port.c. I would say convert the previous patch to make it static, > > and move the export into this patch, but I'm also tempted to leave > > well enough alone here unless there some additional reason to respin > > patch 32. > > I hadn't read this when I sent reply to previous patch v4. Up to you on > whether you tidy up or not. Though I'm fairly sure you'll get > a missing static warning if you build previous patch without a header definition. > Agreed adding static then removing it again would be an option, but > meh, too much noise... The one going the other way (defining a function > before it exists) is probably more important to fix. There's no warning about declaring a function that is never defined, but that's egregious enough to go fixup.
