Hi, I love your patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on v5.17-rc2 next-20220131] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/marek-vasut-gmail-com/PCI-rcar-Finish-transition-to-L1-state-in-rcar_pcie_config_access/20220129-124033 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: arm-randconfig-c002-20220201 (https://download.01.org/0day-ci/archive/20220201/202202012118.qgdNW3Ra-lkp@xxxxxxxxx/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 6b1e844b69f15bb7dffaf9365cd2b355d2eb7579) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/0day-ci/linux/commit/88177fcc2d6d4acbea59c90839882f70b7b774a1 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review marek-vasut-gmail-com/PCI-rcar-Finish-transition-to-L1-state-in-rcar_pcie_config_access/20220129-124033 git checkout 88177fcc2d6d4acbea59c90839882f70b7b774a1 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/pci/controller/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/pci/controller/pcie-rcar-host.c:133:5: warning: no previous prototype for function 'rcar_pci_write_reg_workaround' [-Wmissing-prototypes] int rcar_pci_write_reg_workaround(struct rcar_pcie *pcie, u32 val, unsigned int reg) ^ drivers/pci/controller/pcie-rcar-host.c:133:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int rcar_pci_write_reg_workaround(struct rcar_pcie *pcie, u32 val, unsigned int reg) ^ static drivers/pci/controller/pcie-rcar-host.c:146:5: warning: no previous prototype for function 'rcar_pci_read_reg_workaround' [-Wmissing-prototypes] int rcar_pci_read_reg_workaround(struct rcar_pcie *pcie, u32 *val, unsigned int reg) ^ drivers/pci/controller/pcie-rcar-host.c:146:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int rcar_pci_read_reg_workaround(struct rcar_pcie *pcie, u32 *val, unsigned int reg) ^ static >> drivers/pci/controller/pcie-rcar-host.c:138:3: error: instruction requires: data-barriers __rcar_pci_rw_reg_workaround("str") ^ drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro '__rcar_pci_rw_reg_workaround' "2: isb\n" \ ^ <inline asm>:2:4: note: instantiated into assembly here 2: isb ^ drivers/pci/controller/pcie-rcar-host.c:151:3: error: instruction requires: data-barriers __rcar_pci_rw_reg_workaround("ldr") ^ drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro '__rcar_pci_rw_reg_workaround' "2: isb\n" \ ^ <inline asm>:2:4: note: instantiated into assembly here 2: isb ^ >> drivers/pci/controller/pcie-rcar-host.c:138:3: error: instruction requires: data-barriers __rcar_pci_rw_reg_workaround("str") ^ drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro '__rcar_pci_rw_reg_workaround' "2: isb\n" \ ^ <inline asm>:2:4: note: instantiated into assembly here 2: isb ^ drivers/pci/controller/pcie-rcar-host.c:151:3: error: instruction requires: data-barriers __rcar_pci_rw_reg_workaround("ldr") ^ drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro '__rcar_pci_rw_reg_workaround' "2: isb\n" \ ^ <inline asm>:2:4: note: instantiated into assembly here 2: isb ^ 2 warnings and 4 errors generated. vim +138 drivers/pci/controller/pcie-rcar-host.c 132 133 int rcar_pci_write_reg_workaround(struct rcar_pcie *pcie, u32 val, unsigned int reg) 134 { 135 int error = PCIBIOS_SUCCESSFUL; 136 #ifdef CONFIG_ARM 137 asm volatile( > 138 __rcar_pci_rw_reg_workaround("str") 139 : "+r"(error):"r"(val), "r"(pcie->base + reg) : "memory"); 140 #else 141 rcar_pci_write_reg(pcie, val, reg); 142 #endif 143 return error; 144 } 145 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx