On Sun, Jan 30 2022, Yishai Hadas <yishaih@xxxxxxxxxx> wrote: > @@ -44,6 +45,7 @@ struct vfio_device { > /** > * struct vfio_device_ops - VFIO bus driver device callbacks > * > + * @flags: Global flags from enum vfio_device_ops_flags You add this here, only to remove it in patch 15 again. Leftover from some refactoring? > * @open_device: Called when the first file descriptor is opened for this device > * @close_device: Opposite of open_device > * @read: Perform read(2) on device file descriptor