On Friday 21 January 2022 15:40:49 Martin Mareš wrote:
> Hello!
>
> > + case PCI_HEADER_TYPE_BRIDGE:
> > + if (pci_read_word(d, PCI_STATUS) & PCI_STATUS_CAP_LIST)
> > + {
> > + byte been_there[256];
> > + int where, id;
> > +
> > + memset(been_there, 0, 256);
> > + where = pci_read_byte(d, PCI_CAPABILITY_LIST) & ~3;
> > + while (where && !been_there[where]++)
>
> Please don't. There should be a single implementation of capability list
> walking in libpci, not everybody doing his own.
Current libpci code which walks capability list is in functions
pci_scan_caps() and pci_find_cap(). But pci_find_cap() calls
pci_fill_info() (only with PCI_FILL_CAPS flag). So I'm not sure if it is
a good idea to call pci_find_cap() from pci_generic_fill_info().
