Re: [PATCH v3 2/2] PCI/AER: Enable AER on all PCIe devices supporting it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 19, 2022 at 10:25:50AM -0800, Keith Busch wrote:
> On Wed, Jan 19, 2022 at 10:22:00AM +0100, Stefan Roese wrote:
> > @@ -387,6 +387,10 @@ void pci_aer_init(struct pci_dev *dev)
> >  	pci_add_ext_cap_save_buffer(dev, PCI_EXT_CAP_ID_ERR, sizeof(u32) * n);
> >  
> >  	pci_aer_clear_status(dev);
> > +
> > +	/* Enable AER if requested */
> > +	if (pci_aer_available())
> > +		pci_enable_pcie_error_reporting(dev);
> >  }
> 
> Hasn't it always been the device specific driver's responsibility to
> call this function?

So far it has been done by the driver, because the PCI core doesn't do
it.  But is there a reason it should be done by the driver?  It
doesn't seem necessarily device-specific.

Bjorn



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux