On Tue, Jan 18, 2022 at 06:26:48PM +0100, Borislav Petkov wrote:
On Tue, Jan 18, 2022 at 08:36:56AM -0800, Lucas De Marchi wrote:
I had the impression the subject/title should be imperative, with it
more relaxed in the body. It seems we have one more difference among
subsystems and I will adapt on next submissions to x86.
We have written it down properly, in case it explains it better:
"The tip tree maintainers set value on following these rules, especially
on the request to write changelogs in imperative mood and not
impersonating code or the execution of it. This is not just a whim of
the maintainers. Changelogs written in abstract words are more precise
and tend to be less confusing than those written in the form of novels."
from Documentation/process/maintainer-tip.rst
nice, thanks. I had missed this. It certainly makes it easier to adapt
the style when crossing subystems
> So I wonder: why can't you simply pass in a static struct chipset *
> pointer into the early_qrk[i].f function and in there you can set
> QFLAG_APPLIED or so, so that you can mark that the quirk is applied by
> using the nice, per-quirk flags someone has already added instead of
> this ugly static variable?
It seems you prefer v1. See 20211218061313.100571-1-lucas.demarchi@xxxxxxxxx
I do?
I don't see there:
early_qrk[i].f(&early_qrk[i], num, slot, func)
so that the ->f callback can set the flags. Or at least the flags passed
in.
Indeed not exactly the same. In v1 we have
applied = early_qrk[i].f(num, slot, func);
because I was trying to keep the logic that uses and the one that checks
the value in the same place. With your suggestion the logic to set the
flag would need to move to the called functions, while checking for the
flag would continue to be in the caller.
If it is not clear what I mean, pls say so and I'll try to produce an
example diff ontop.
Although in the review Bjorn suggested just splitting the commit, it was
also mentioned that the PCI subsystem has no such logic in its
equivalent pci_do_fixups(): a quirk/fixup needing that should instead
use a static local.
Why?
I think to make it similar how the PCI fixups work. Anyway, do you
prefer that I change the QFLAG_APPLY_ONCE as above (including
nvidia_bugs() and ati_bugs()) or a very minimal fix like below and
nothing else?
------8<------
diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 391a4e2b8604..7b2a3230c42a 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -591,6 +591,13 @@ static void __init intel_graphics_quirks(int num, int slot, int func)
u16 device;
int i;
+ /*
+ * Already reserved for integrated graphics, nothing to do for other
+ * (discrete) cards.
+ */
+ if (resource_size(&intel_graphics_stolen_res))
+ return;
+
device = read_pci_config_16(num, slot, func, PCI_DEVICE_ID);
for (i = 0; i < ARRAY_SIZE(intel_early_ids); i++) {
@@ -703,7 +710,7 @@ static struct chipset early_qrk[] __initdata = {
{ PCI_VENDOR_ID_INTEL, 0x3406, PCI_CLASS_BRIDGE_HOST,
PCI_BASE_CLASS_BRIDGE, 0, intel_remapping_check },
{ PCI_VENDOR_ID_INTEL, PCI_ANY_ID, PCI_CLASS_DISPLAY_VGA, PCI_ANY_ID,
- QFLAG_APPLY_ONCE, intel_graphics_quirks },
+ 0, intel_graphics_quirks },
/*
* HPET on the current version of the Baytrail platform has accuracy
* problems: it will halt in deep idle state - so we disable it.
------8<------
thanks
Lucas De Marchi
