Re: [RFC PATCH 1/3] Add support for seven more indicators in enclosure driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 17, 2022 at 10:17:56PM -0600, Stuart Hayes wrote:
> This patch adds support for seven additional indicators (ok, rebuild,
> prdfail, hotspare, ica, ifa, disabled) to the enclosure driver, which
> currently only supports three (fault, active, locate). It also reduces
> duplicated code for the set and show functions for the sysfs attributes
> for all of the indicators, and allows users of the driver to provide
> common get_led and set_led callbacks to control all indicators (though
> it continues to support the existing callbacks for the three currently
> supported indicators, so it does not require any changes to code that
> already uses the enclosure driver).
> 
> This will be used by the pcie_em driver.
> 
> Signed-off-by: Stuart Hayes <stuart.w.hayes@xxxxxxxxx>
> ---
>  drivers/misc/enclosure.c  | 189 ++++++++++++++++++++++----------------
>  include/linux/enclosure.h |  22 +++++
>  2 files changed, 133 insertions(+), 78 deletions(-)

You did not document your new sysfs files in Documentation/ABI/ anywhere
:(




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux