Re: [RFC 13/32] hwmon: Kconfig: add HAS_IOPORT dependencies

[Guenter Roeck <linux@xxxxxxxxxxxx>]

On 12/27/21 8:42 AM, Niklas Schnelle wrote:
> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. We thus need to add HAS_IOPORT as dependency for
> those drivers using them.

Similar to watchdog, I don't understand when HAS_IOPORT is needed and when not,
as there are more hwmon drivers using IO ports than the ones listed below.

Guenter

> Co-developed-by: Arnd Bergmann <arnd@xxxxxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxxxx>
> Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>
> ---
>   drivers/hwmon/Kconfig | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 09397562c396..c1a2d8ac96fd 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -547,6 +547,7 @@ config SENSORS_SPARX5
>   
>   config SENSORS_F71805F
>   	tristate "Fintek F71805F/FG, F71806F/FG and F71872F/FG"
> +	depends on HAS_IOPORT
>   	depends on !PPC
>   	help
>   	  If you say yes here you get support for hardware monitoring
> @@ -558,6 +559,7 @@ config SENSORS_F71805F
>   
>   config SENSORS_F71882FG
>   	tristate "Fintek F71882FG and compatibles"
> +	depends on HAS_IOPORT
>   	depends on !PPC
>   	help
>   	  If you say yes here you get support for hardware monitoring
> @@ -761,6 +763,7 @@ config SENSORS_CORETEMP
>   
>   config SENSORS_IT87
>   	tristate "ITE IT87xx and compatibles"
> +	depends on HAS_IOPORT
>   	depends on !PPC
>   	select HWMON_VID
>   	help
> @@ -1387,6 +1390,7 @@ config SENSORS_LM95245
>   
>   config SENSORS_PC87360
>   	tristate "National Semiconductor PC87360 family"
> +	depends on HAS_IOPORT
>   	depends on !PPC
>   	select HWMON_VID
>   	help
> @@ -1401,6 +1405,7 @@ config SENSORS_PC87360
>   
>   config SENSORS_PC87427
>   	tristate "National Semiconductor PC87427"
> +	depends on HAS_IOPORT
>   	depends on !PPC
>   	help
>   	  If you say yes here you get access to the hardware monitoring
> @@ -1432,6 +1437,7 @@ config SENSORS_NTC_THERMISTOR
>   
>   config SENSORS_NCT6683
>   	tristate "Nuvoton NCT6683D"
> +	depends on HAS_IOPORT
>   	depends on !PPC
>   	help
>   	  If you say yes here you get support for the hardware monitoring
> @@ -1442,6 +1448,7 @@ config SENSORS_NCT6683
>   
>   config SENSORS_NCT6775
>   	tristate "Nuvoton NCT6775F and compatibles"
> +	depends on HAS_IOPORT
>   	depends on !PPC
>   	depends on ACPI_WMI || ACPI_WMI=n
>   	select HWMON_VID
> @@ -1664,6 +1671,7 @@ config SENSORS_SIS5595
>   
>   config SENSORS_DME1737
>   	tristate "SMSC DME1737, SCH311x and compatibles"
> +	depends on HAS_IOPORT
>   	depends on I2C && !PPC
>   	select HWMON_VID
>   	help
> @@ -1707,6 +1715,7 @@ config SENSORS_EMC6W201
>   
>   config SENSORS_SMSC47M1
>   	tristate "SMSC LPC47M10x and compatibles"
> +	depends on HAS_IOPORT
>   	depends on !PPC
>   	help
>   	  If you say yes here you get support for the integrated fan
> @@ -1741,6 +1750,7 @@ config SENSORS_SMSC47M192
>   
>   config SENSORS_SMSC47B397
>   	tristate "SMSC LPC47B397-NC"
> +	depends on HAS_IOPORT
>   	depends on !PPC
>   	help
>   	  If you say yes here you get support for the SMSC LPC47B397-NC
> @@ -1754,6 +1764,7 @@ config SENSORS_SCH56XX_COMMON
>   
>   config SENSORS_SCH5627
>   	tristate "SMSC SCH5627"
> +	depends on HAS_IOPORT
>   	depends on !PPC && WATCHDOG
>   	select SENSORS_SCH56XX_COMMON
>   	select WATCHDOG_CORE
> @@ -1767,6 +1778,7 @@ config SENSORS_SCH5627
>   
>   config SENSORS_SCH5636
>   	tristate "SMSC SCH5636"
> +	depends on HAS_IOPORT
>   	depends on !PPC && WATCHDOG
>   	select SENSORS_SCH56XX_COMMON
>   	select WATCHDOG_CORE
> @@ -1995,6 +2007,7 @@ config SENSORS_VIA686A
>   
>   config SENSORS_VT1211
>   	tristate "VIA VT1211"
> +	depends on HAS_IOPORT
>   	depends on !PPC
>   	select HWMON_VID
>   	help
> @@ -2114,6 +2127,7 @@ config SENSORS_W83L786NG
>   
>   config SENSORS_W83627HF
>   	tristate "Winbond W83627HF, W83627THF, W83637HF, W83687THF, W83697HF"
> +	depends on HAS_IOPORT
>   	depends on !PPC
>   	select HWMON_VID
>   	help
> @@ -2126,6 +2140,7 @@ config SENSORS_W83627HF
>   
>   config SENSORS_W83627EHF
>   	tristate "Winbond W83627EHF/EHG/DHG/UHG, W83667HG"
> +	depends on HAS_IOPORT
>   	depends on !PPC
>   	select HWMON_VID
>   	help