On Wed, 2011-09-14 at 09:24 -0500, Jon Mason wrote: > The issue with calling pcie_bus_configure_settings directly with the > root bus is the "safe" option. Doing so would make the MPS uniform > from the root bus level instead of the root port level, thus making > the system-wide MPS the smallest of the root complex instead of the > smallest on the root port fabric. However, since every arch is most > likely going to have to iterate over the children of the root bus, it > might make sense to have a helper function do that. Ok, I get it. makes sense. On power we only ever have one RC per PHB so I didn't quite see the issue but yes, it's a good idea. I'll review the patch more later today hopefully. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html